-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

=pod

One thing that I learned at my first job was the complaining about
things in code comments is really annoying.  I remember saying to
myself, "don't complain in the comments, complain on your blog."

Well, I found myself doing this during a recent Java project, so I'm
going to follow my own rule.  Here's what I want to do:

    lang:Perl
    use Path::Class 'file';
    file(CMS->root, sprintf("%s.%04d.txt", (join '/', @pathparts), $revision))

Here's how it turned out:

    lang:Java
    protected File getFile(int revision) throws IllegalArgumentException
    {
        if(revision < 0){
            throw new IllegalArgumentException("revision must be non-negative");
        }
    
        String path = "";
        for(String part : pathParts) {
            path += (path.length() == 0 ? "" : File.separator) + part;
        }
        return new File(CMS.cmsPath, 
                        new Formatter().format("%s.%04d.txt", 
                                                path, revision));
    }

You have got to be kidding me.

(And no, the filesystem-based CMS wasn't my idea.  It's a rewrite of
existing code.)

B<UPDATE:> I cleaned up the Java code a bit.  I think my point is
valid -- it takes a lot of writing to not say very much.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHZtPK2rw+dVvzZm0RAg+xAJ45/k4MWmhPgbLmovv5tn6kDfHodQCdEKdL
UY3duoG75JHcauXVCTLkw20=
=FJQm
-----END PGP SIGNATURE-----